dolthub / doltpy

A Python API for Dolt
Apache License 2.0
55 stars 13 forks source link

interface, logging, process management, and testing improvements, as well as bug fixes #50

Closed oscarbatori closed 4 years ago

oscarbatori commented 4 years ago

This pull request addresses the following issues:

andy-wm-arthur commented 4 years ago

These changes look good, but they don't exactly solve the core problem. As we discussed this morning, we have to weigh the tradeoffs of using the sql-server to read/write the repo vs using the CLI. As I see it:

oscarbatori commented 4 years ago

@timsehn / @zachmu - do you guys have an opinion here?

timsehn commented 4 years ago

I like using the SQL server in doltpy. The problems are not going away because we avoid the path. This needs to work.

Maybe we can provide both interfaces and a switch? This means if one is blocked, you can try the other and see if it works. This will give us better repros.

For avoiding the MySQL client, we could use dolt sql -r csv as the read interafce. On the write path we could just assemble the queries and pipe in via dolt sql < <file>?

zachmu commented 4 years ago

The switch idea definitely seems like a good way to reproduce and debug problems as we keep working on this.