search

dolthub / go-mysql-server

A MySQL-compatible relational database with a storage agnostic query engine. Implemented in pure Go.
Apache License 2.0
2.37k stars 211 forks source link

Embed the `embedded.Tracer` into memTracer, to fulfil the updated interface #2739

Closed samjewell closed 6 days ago

samjewell commented 2 weeks ago

I was trying to use this project go-mysql-server as a dependency alongside github.com/grafana/grafana-plugin-sdk-go/data. But the latter project depends on:

When I updated my go modules with go mod tidy I started to hit a compilation error:

# github.com/dolthub/go-mysql-server/test
/Users/samjewell/go/pkg/mod/github.com/dolthub/go-mysql-server@v0.18.1/test/mem_tracer.go:22:2: could not import go.opentelemetry.io/otel/trace/embedded (open : no such file or directory)
FAIL    github.com/grafana/poc-sql-expressions-embedded-sql/dolthub-go-mysql-server [build failed]
FAIL

Hence this change 🙏

samjewell commented 2 weeks ago

@jycor / @Hydrocharged any thoughts on this one 🙏 ?

zachmu commented 2 weeks ago

@max-hoffman you want to take a look at this? Not sure how it affects our upstreams.

max-hoffman commented 2 weeks ago

@max-hoffman you want to take a look at this? Not sure how it affects our upstreams.

The hosted API and DoltHub remote API are the only services that use OTEL as far as I can tell. So if the version bump is not backwards compatible LD will need a PR for interface changes. Removing the OTEL dependency from GMS would probably also work. Merging this PR as is would probably be OK.

samjewell commented 6 days ago

Hey team. Any update on this? It's something of a thorn in my side right now, so I'm interested 👀

max-hoffman commented 6 days ago

I'll merge, if there are further conflicts I will loop back and just remove the dependency.

max-hoffman commented 6 days ago

Thanks for taking the time to contribute @samjewell :).