dolthub / vitess

Vitess is a database clustering system for horizontal scaling of MySQL.
http://vitess.io
Apache License 2.0
22 stars 20 forks source link

Consistently using pointer to AliasedValues in InsertRows interface, never values. #337

Closed nicktobey closed 5 months ago

nicktobey commented 5 months ago

Once again, golang reminds me that a value type implementing an interface forces the pointer type to also implement the interface, and mixing the two messes up our runtime type reflection.

I changed all uses of the AliasedValues in InsertRows interface to be pointers so that we can interact with them consistently on the GMS side.