dom-buri / pe

0 stars 0 forks source link

Entry of Email without domain name passed #2

Open dom-buri opened 9 months ago

dom-buri commented 9 months ago

The email that I used is test@example and the dentist was successfully created. However, there is a missing domain name, for example .com.

Screenshot 2023-11-17 at 4.15.22 PM.png

nus-se-bot commented 9 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Email validation check

image.png

Currently the app allows be to add emails with invalid format such as 1@12. Perhaps, an additional check for valid domain would be more useful to users so that they don't enter wrong emails.


[original: nus-cs2103-AY2324S1/pe-interim#4827] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

https://stackoverflow.com/questions/20573488/why-does-html5-form-validation-allow-emails-without-a-dot?noredirect=1&lq=1

Valid point. However, even 1@12 could be considered as a valid email (localhost)

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]