search

dom-buri / pe

0 stars 0 forks source link

The `Tag` class is missing from the Class Diagram #21

Open dom-buri opened 9 months ago

dom-buri commented 9 months ago

As the Tag class belongs in the Model component, the class diagram should also include the Tag class in the diagram. Screenshot 2023-11-17 at 5.38.16 PM.png

nus-pe-script commented 9 months ago

Team's Response

Thank you for your report. However, kindly note that the Model Diagram is updated from AB3 version in a sense that attributes of an object are put within the Class of the object. In this case, Tag is one of the attributes of a Person and it has been included as Set<Tag>. A similar observation can be made for other objects like Specialization for a Dentist object.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Now that you mentioned, all the classes including Tag, Specialization, BirthDate, TreatmentDate... should all be classes instead since they are all classes belonging to the Model component.

I think that putting including the Set<Tag> in the Person class without creating the Tag class is incorrect.