search

dom-buri / pe

0 stars 0 forks source link

Email does not accept two consecutive special characters #3

Open dom-buri opened 9 months ago

dom-buri commented 9 months ago

In the error message, The local-part should only contain alphanumeric characters and these special characters, excluding the parentheses, (+_.-). The local-part may not start or end with any special characters. However, when I used 2 special characters __, I was unable to create a new dentist even though it satisfies the requirements given in the error message. This might be difficult for a user if they wish to add such an email. One improvement would be to change the error message or the validity checking so that they are consistent.

Command used add-dentist n/Dentist 2 p/91231234 s/ENDODONTICS y/3 e/test__test@example.com

Screenshot 2023-11-17 at 4.17.03 PM.png

nus-se-script commented 9 months ago

Team's Response

This is a valid point. However, we are not able to make such changes in 1.4.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: In the error message, it stated that I could have special characters in the email. However, when I have two special characters, the behaviour doesn't match the description of the error message. I think it is in scope.