search

dom111 / webdav-js

A simple WebDAV client written in JS for use as a bookmarklet, or integration into a web server.
MIT License
91 stars 18 forks source link

Recognize .flac, .mka and .mkv #70

Closed chrysn closed 4 years ago

chrysn commented 4 years ago

These files can be played (at least by Firefox on Linux, didn't test others), and are widely used (eg. for high quality recordings).

chrysn commented 4 years ago

Adding .mkv and .mka (Matroska) files.

Eventually, it'd be nice to use an externally maintained database, and ideally use media types (<getcontenttype>), but those are ones I found on my server.

dom111 commented 4 years ago

Yeah, agreed. In the latest changes I removed the mimeType checking as that was conflicting with the approach I wanted to take for allowing the previews to work, but it might be nice to default back to using those. Before changing that too much though, I think I'll replace the lightbox and tackle type checking as part of that process.

This looks good to go though! I didn't realise that WebMs are in a Matroska container too... Learned something thanks to this PR! :)