search

dom96 / choosenim

Tool for easily installing and managing multiple versions of the Nim programming language.
BSD 3-Clause "New" or "Revised" License
680 stars 64 forks source link

Error on 404 #277

Closed ire4ever1190 closed 3 years ago

ire4ever1190 commented 3 years ago

Checks the Response objects http code and returns error if 404 instead of writing an empty tar file and trying to extract that.

Right now it only checks for 404, should it return an error unless the http code is 2xx?

ire4ever1190 commented 3 years ago

but really this should be fixed in puppy too

This is by design in puppy as shown in the readme. I have left a question though in the puppy repo asking if the exceptions could be thrown when using the basic proc (https://github.com/treeform/puppy/issues/31)