double log output when using httpbeast

dom96 / jester

A sinatra-like web framework for Nim.

MIT License

1.56k stars 120 forks source link

double log output when using httpbeast #286

Closed niv closed 2 years ago

niv commented 2 years ago

Run jester with httpbeast
Have custom logging already set up
HttpBeast adds a second logger (passed through settings/initSettings/...) with no way to dodge this short of rewriting the whole serve*(Jester) function.
This results in all logging output on stdout being duplicated

ThomasTJdev commented 2 years ago

I agree. It would be nice to be able to specify the logging. For now I use something like this:

if logging.getHandlers().len() > 0:
  for logger in getHandlers():
    logger.fmtStr = "[$datetime] - $levelname: "
    logger.levelThreshold = (when defined(release): lvlInfo else: lvlAll)

ThomasTJdev commented 2 years ago

I have a PR for this one on my to-do list. @dom96, do you have any preferences to a solution?

ohPaco commented 2 years ago

@ThomasTJdev would like to see your changes for the fix, had you closed the PR?

ThomasTJdev commented 2 years ago

@ohPaco I have not started on it yet. I would prefer to have dom96's thoughts on a preferable solution before starting.

ohPaco commented 2 years ago

@ThomasTJdev understood. @dom96 would you be able to comment on this issue?

dom96 commented 2 years ago

I'm not sure what options there are. I would need to have a look to know. If you guys had a look and have some ideas let me know and we can discuss which one would be best.

ohPaco commented 2 years ago

I'm not sure what options there are. I would need to have a look to know. If you guys had a look and have some ideas let me know and we can discuss which one would be best.

@ThomasTJdev having looked into the issue, do you have any ideas?