dom96 / jester

A sinatra-like web framework for Nim.
MIT License
1.56k stars 120 forks source link

Add startup callback to settings for httpbeast #318

Closed ThomasTJdev closed 11 months ago

ThomasTJdev commented 11 months ago

Hi Dom,

A follow-up PR from the httpbeast PR https://github.com/dom96/httpbeast/pull/89 :)

Would this be a possible PR? Or are there any changes you would like to see?

dom96 commented 11 months ago

Weirdly (and this is unrelated to this PR) it seems @iffy's github action is installing the stable Nim, rather than the one defined by nimversion.

iffy commented 11 months ago

install-nim is expecting a variable named version not nimversion

Warning: Unexpected input(s) 'nimversion', valid inputs are ['version']

iffy commented 11 months ago

Change https://github.com/dom96/jester/blob/185c61066e3522f8e2599ceeeb0cafe7ff669f8f/.github/workflows/main.yml#L29

to

          version: ${{ matrix.nimversion }}