dom96 / nim-in-action-code

Nim in Action code samples
https://book.picheta.me
199 stars 28 forks source link

Remove deprecated ident type, getNum -> getInt #13

Open dlesnoff opened 2 years ago

dlesnoff commented 2 years ago

I have, in chapter 9 about the config macro:

Oh sorry for the branch choice, these changes have been added by ulterior versions than 1.2.6, I have run code with 1.6.6 (current latest stable).

dom96 commented 2 years ago

When did these changes become required for successful compilation? Do we need a new branch for that version?

dlesnoff commented 2 years ago

Actually no, I have done testing with 1.2.6, I get the same warnings (deprecated since 0.18.1 !) and the same getNum error. Obviously, I got same error and warnings with ulterior 1.4.8 version.

dom96 commented 2 years ago

Do you get these as warnings or do they fail compilation? The branches only need to compile successfully.

dlesnoff commented 2 years ago

I get one error because getNum() does not exist in the json library