Fix MysqlUpsertAssembler for support MySQL8

domaframework / doma

DAO oriented database mapping framework for Java

https://doma.readthedocs.io/

Apache License 2.0

444 stars 70 forks source link

Fix MysqlUpsertAssembler for support MySQL8 #1079

Closed momosetkn closed 7 months ago

momosetkn commented 7 months ago

wait for add MySQL8 dialect

nakamura-to commented 7 months ago

@momosetkn I have supported MySQL 8 in #1082.

Could you pass MysqlDialect#version to the constructor of the existing MysqlUpsertAssembler and absorb the differences between MySQL 5 and 8 with a conditional branch? This approach allows for less code duplication than adding a new Mysql8UpsertAssembler.

momosetkn commented 7 months ago

ok, I Unificated Mysql8UpsertAssembler.java and MysqlUpsertAssembler.java.