5.7.7, bimi logo and errors

[Pascal76]

Hello,

Just a question:

cases : 1/ checkdmarc n1.e-nocibe.fr 2/ checkdmarc m11.email.samsung.com

Why don't you add a json['bimi']['image']['errors'] for image issues as you do with certificate issues with json['bimi']['certificate']['validation_errors'] ?

Ex1:

• on json['bimi']['image']['errors'] "Unable to download https://www.nocibe.fr/bibliotheque/documents/bimi.svg - 400 Client Error: Bad Request for url: https://www.nocibe.fr/bibliotheque/documents/bimi.svg"
• on json['bimi']['warnings'] "Unable to download the logo"

Ex2:

• on json['bimi']['image']['errors'] ["The SVG version must be 1.2, not 1.1","The SVG base profile must be tiny-ps"]
• on json['bimi']['warnings'] "The logo does not respect the specifications"

The goal is to be able to extract the error per type (certificate, image, ...)

[Pascal76]

Thank you @seanthegeek :)

[Pascal76]

@seanthegeek

Add an error message to ["bimi"]["image]["error"] instead of ["bimi"]["warnings"] when a BIMI image download fails

Build 5.7.9 checkdmarc n1.e-nocibe.fr

"certificate": { "error": "Failed to download BIMI image at https://www.nocibe.fr/bibliotheque/documents/bimi.svg - 400 Client Error: Bad Request for url: https://www.nocibe.fr/bibliotheque/documents/bimi.svg" },

It is not located in ["bimi"]["image]["error"]

[Pascal76]

more over you don't do exhaustive checks concerning the logo

ex: m11‍.‍email‍.‍samsung‍.‍com returns

  "validation_errors": [
    "The SVG version must be 1.2, not 1.1",
    "The SVG base profile must be tiny-ps"
  ]

BUT there are :
. missing or empty 'baseProfile' attribute . missing Title element . not allowed 'x', 'y', 'overflow' attributes

I don't know if you check the logo is a square too and if it is located on an https URL and the length of the title and the logo format (not a png)...