search

domainaware / checkdmarc

A parser for SPF and DMARC DNS records
https://domainaware.github.io/checkdmarc
Apache License 2.0
247 stars 77 forks source link

dns_lookups for domains with failing SPF #18

Closed schack closed 6 years ago

schack commented 6 years ago

Hi It would be nice if domains with failing SPF could have "dns_lookups" set in the result. Example: ebay.com

"spf": { "record": "v=spf1 include:s._spf.ebay.com include:c._spf.ebay.com include:p._spf.ebay.com include:p2._spf.ebay.com ~all", "valid": false, "error": "Parsing the SPF record requires 11/10 maximum DNS lookups https://tools.ietf.org/html/rfc7208#section-4.6.4" },

seanthegeek commented 6 years ago

This will require a lot of refactoring, so moving this to milestone 2.1

malvidin commented 6 years ago

Is this complete?

seanthegeek commented 6 years ago

I still need to work on this one

malvidin commented 6 years ago

Do you have any example domains or know of misconfigured domains that currently exceed 10 DNS lookups for testing?

schack commented 6 years ago

Yes. elgiganten.dk alka.dk Many more domains with all sorts of SPF errors can be found here: https://status.dmarc.dk/spf-defektlisten (They all fail when usings Kittermans pyspf)

malvidin commented 6 years ago

Thanks you for the resources, I will see what I can do to help resolve this issue

seanthegeek commented 6 years ago

This has finally been implemented in 2.6.0. Sorry it took so long!

seanthegeek commented 6 years ago

Please upgrade to 2.6.1 I fixed a mistake in the way I was generating exceptions