search

domainaware / checkdmarc

A parser for SPF and DMARC DNS records
https://domainaware.github.io/checkdmarc
Apache License 2.0
245 stars 76 forks source link

Exception: 'error', "query() got an unexpected keyword argument 'lifetime'" #47

Closed ioncebotari closed 5 years ago

ioncebotari commented 5 years ago

When calling checkdmarc.check_domains(['mail.com']) I am getting the following error:

'error', "query() got an unexpected keyword argument 'lifetime'"

instead of valid data. Removing the argument for lifetime on lines 657 and 665 of checkdmark.py fixes the error.

If I don't remove the lifetime arguments this is what I get: OrderedDict([('domain', 'mail.com'), ('base_domain', 'mail.com'), ('dnssec', True), ('ns', OrderedDict([('hostnames', []), ('error', "query() got an unexpected keyword argument 'lifetime'")])), ('mx', OrderedDict([('hosts', []), ('error', "query() got an unexpected keyword argument 'lifetime'")])), ('spf', OrderedDict([('record', None), ('valid', False), ('error', "query() got an unexpected keyword argument 'lifetime'")])), ('dmarc', OrderedDict([('record', None), ('valid', False), ('location', None), ('error', "query() got an unexpected keyword argument 'lifetime'")]))])

seanthegeek commented 5 years ago

I'm unable to reproduce this issue. What version of pydns are you using?

seanthegeek commented 5 years ago

This should be fixed in checkdmarc 4.2.3, which sets a required minimum dnspython version.