search

domainaware / parsedmarc

A Python package and CLI for parsing aggregate and forensic DMARC reports
https://domainaware.github.io/parsedmarc/
Apache License 2.0
1.01k stars 219 forks source link

number_of_replicas cannot be set without setting number_of_shards #269

Closed glade-at-gigwell closed 2 years ago

glade-at-gigwell commented 3 years ago

In a simple setup, having 1 shard + 1 replica causes elasticsearch to remain in the YELLOW state. In order to fix this, we should set the number_of_replicas to 0. However, the indentation of the settings code currently requires number_of_shards to be defined for it to read the number_of_replicas value.

glade-at-gigwell commented 3 years ago

https://github.com/domainaware/parsedmarc/blob/master/parsedmarc/cli.py#L400-L403

knightian commented 2 years ago

https://github.com/domainaware/parsedmarc/blob/master/parsedmarc/cli.py#L400-L403

I did this to set the default to 0 replication I think that makes sense really

https://github.com/domainaware/parsedmarc/pull/274

seanthegeek commented 2 years ago

Fixed in PR #274 , which will be included in a release soon.