domainaware / parsedmarc

A Python package and CLI for parsing aggregate and forensic DMARC reports
https://domainaware.github.io/parsedmarc/
Apache License 2.0
986 stars 214 forks source link

Add Dockerfile & build/push task #316

Closed nathanthorpe closed 2 years ago

nathanthorpe commented 2 years ago

Note that it only pushes the docker image on a release, so using the releases option in GitHub is required.

It would be nice to have an official docker image for running on container platforms.

@seanthegeek I'm curious if you prefer to use ghcr or DockerHub. If you want to use DockerHub then I will remove the push action. Also let me know your thoughts on the release process.

If this is merged, please use the Squash and merge option so that the test commits are squashed.

codecov[bot] commented 2 years ago

Codecov Report

Merging #316 (230314e) into master (bfd1aa8) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #316   +/-   ##
=======================================
  Coverage   61.40%   61.40%           
=======================================
  Files           8        8           
  Lines        1241     1241           
=======================================
  Hits          762      762           
  Misses        479      479           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bfd1aa8...230314e. Read the comment docs.

seanthegeek commented 2 years ago

Thanks! Your implementation of a container looks much cleaner than some others I have seen. My goal for this weekend is to start using GitHub releases to deploy documentation and packages, instead of manually deploying new releases.