domainaware / parsedmarc

A Python package and CLI for parsing aggregate and forensic DMARC reports
https://domainaware.github.io/parsedmarc/
Apache License 2.0
966 stars 210 forks source link

Replace type checks with isinstance #427

Closed bencomp closed 9 months ago

bencomp commented 11 months ago

This should remove all Flake8 E721 errors that cause build failures.

codecov[bot] commented 11 months ago

Codecov Report

Patch coverage: 82.35% and no project coverage change.

Comparison is base (6c84cfb) 58.35% compared to head (1af1767) 58.35%. Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #427 +/- ## ======================================= Coverage 58.35% 58.35% ======================================= Files 10 10 Lines 1340 1340 ======================================= Hits 782 782 Misses 558 558 ``` | [Files Changed](https://app.codecov.io/gh/domainaware/parsedmarc/pull/427?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=domainaware) | Coverage Δ | | |---|---|---| | [parsedmarc/\_\_init\_\_.py](https://app.codecov.io/gh/domainaware/parsedmarc/pull/427?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=domainaware#diff-cGFyc2VkbWFyYy9fX2luaXRfXy5weQ==) | `61.73% <80.00%> (ø)` | | | [parsedmarc/utils.py](https://app.codecov.io/gh/domainaware/parsedmarc/pull/427?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=domainaware#diff-cGFyc2VkbWFyYy91dGlscy5weQ==) | `69.35% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

AnaelMobilia commented 10 months ago

Dear @bencomp ,

It looks like @seanthegeek make some flake8 E721 issues. I suggest to rebase your PR on current main.

Bests regards,

seanthegeek commented 9 months ago

I already did this. Thanks.