Closed Kuzuto closed 9 months ago
Patch coverage: 84.21%
and no project coverage change.
Comparison is base (
6c84cfb
) 58.35% compared to head (2d6fd3c
) 58.35%. Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I'm not a maintainer, just a bystander here, but if it helps, here are some suggestions to increase the chance of acceptance:
type
to instanceof
, which may be perfectly reasonable but have no explanation and no relation to the zlib change.I'm not a maintainer, just a bystander here, but if it helps, here are some suggestions to increase the chance of acceptance:
* Give the PR a meaningful title and description. * Don't mix multiple logical changes in a single PR; here you seem to have the GzipFile to zlib changes (for issue [Invalid reports from mimecastreport.com due to trailing \r\n on gzip data #429](https://github.com/domainaware/parsedmarc/issues/429)) and a bunch of unrelated changes from `type` to `instanceof`, which may be perfectly reasonable but have no explanation and no relation to the zlib change.
Thanks for the tips. I can see what you mean, even I added some notes about the other changes. I just got the impression the PR will be more "valid" if tests was passing. If he merges the PR #427 first, he will see my code only changes the init.py file.
Dear @Kuzuto ,
It looks like @seanthegeek make some flake8 E721 issues. I suggest to rebase your PR on current main.
Bests regards,
I fixed the type checks, and I'll change to zlib. Thanks.
changed GzipFile to zlib. Mimecast reports gets decompressed and other .gz as well