Closed seanthegeek closed 4 months ago
Attention: 134 lines
in your changes are missing coverage. Please review.
Comparison is base (
100f12e
) 58.42% compared to head (009f1d6
) 54.29%. Report is 2 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
parsedmarc/__init__.py | 24.29% | 134 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Ok. I think initial SMTP TLS report support is done, including JSON, CSV, Elasticsearch, and Splunk output, but I haven't done much testing yet
Other steps that are needed:
I was able to reuse existing code to create SMTP TLS report output support for Kafka, S3, Log Analytics, and Syslog. I have not tested any of these and testing would be appreciated.
@seanthegeek I'll see if I can test it for Log Analytics. But I first need an SMTP TLS report.
Hi @seanthegeek
I haven't worked in a Kafka environment/dealing with DMARC since 2020. I can reach out to some old coworkers though and see if they can help out.
Hi @seanthegeek it's been a while since I've looked at this but the changes in s3.py look good to me 👍
As far as I can tell the syslog looks ok, I'm not able to test though.
@seanthegeek Created a Pull request #459 with some fixes and documentation.
I have also tested the application and it works now.
This is a draft PR. I need some help working on it.