domainaware / parsedmarc

A Python package and CLI for parsing aggregate and forensic DMARC reports
https://domainaware.github.io/parsedmarc/
Apache License 2.0
962 stars 210 forks source link

Add support for SMTP TLS reports #453

Closed seanthegeek closed 4 months ago

seanthegeek commented 6 months ago

This is a draft PR. I need some help working on it.

codecov[bot] commented 6 months ago

Codecov Report

Attention: 134 lines in your changes are missing coverage. Please review.

Comparison is base (100f12e) 58.42% compared to head (009f1d6) 54.29%. Report is 2 commits behind head on master.

Files Patch % Lines
parsedmarc/__init__.py 24.29% 134 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #453 +/- ## ========================================== - Coverage 58.42% 54.29% -4.13% ========================================== Files 11 11 Lines 1347 1501 +154 ========================================== + Hits 787 815 +28 - Misses 560 686 +126 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

seanthegeek commented 6 months ago

Ok. I think initial SMTP TLS report support is done, including JSON, CSV, Elasticsearch, and Splunk output, but I haven't done much testing yet

Other steps that are needed:

seanthegeek commented 6 months ago

I was able to reuse existing code to create SMTP TLS report output support for Kafka, S3, Log Analytics, and Syslog. I have not tested any of these and testing would be appreciated.

rubeste commented 6 months ago

@seanthegeek I'll see if I can test it for Log Analytics. But I first need an SMTP TLS report.

mikesiegel commented 6 months ago

Hi @seanthegeek

I haven't worked in a Kafka environment/dealing with DMARC since 2020. I can reach out to some old coworkers though and see if they can help out.

tom-henderson commented 6 months ago

Hi @seanthegeek it's been a while since I've looked at this but the changes in s3.py look good to me 👍

chris-y commented 6 months ago

As far as I can tell the syslog looks ok, I'm not able to test though.

rubeste commented 5 months ago

@seanthegeek Created a Pull request #459 with some fixes and documentation.

rubeste commented 5 months ago

I have also tested the application and it works now.