Closed nhairs closed 9 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
100f12e
) 58.42% compared to head (a93fa08
) 58.42%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks!
This PR:
dmarc_ruf_report_linkedin.eml
with line endings converted to CRLF to ensure there is at least one forensic sample with the line endings..gitattributes
file that ensures that thesamples/
directory is treated as binary data. Without this git would treat this data as text data and automatically convert between/r/n
(CRLF / DOS) line endings and/n
(UNIX) line endings when files are checked out. This is important for ensuring that our parsing logic can be tested on both types of line endings.Test Plan
Mimecast Regression
1de4a94c3787d2470e4dacd8e0de1b4027bc0f21
(parent of commit that fixed mimecast issue)parsedmarc.InvalidAggregateReport: Invalid archive file: Not a gzipped file (b'\r\n')
Forensic sample with CRLF
file samples/forensic/dmarc_ruf_report_linkedin.crlf.eml
Aggregate sample with CRLF
file samples/aggregate/mimecast-weird-gzip.eml