search

domaindrivendev / Swashbuckle.AspNetCore

Swagger tools for documenting API's built on ASP.NET Core
MIT License
5.26k stars 1.32k forks source link

Types with TryParse must be set with type string #3108

Closed jgarciadelanoceda closed 1 month ago

jgarciadelanoceda commented 1 month ago

Fixes #3105 It's not a full rollback of #2980.. But almost, now it takes into account the Enum if the apiParameter.Type is Enum

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.50%. Comparing base (a42d8c9) to head (3c2802f).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3108 +/- ## ======================================= Coverage 90.50% 90.50% ======================================= Files 76 76 Lines 3116 3116 Branches 515 516 +1 ======================================= Hits 2820 2820 Misses 296 296 ``` | [Flag](https://app.codecov.io/gh/domaindrivendev/Swashbuckle.AspNetCore/pull/3108/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Richard+Morris) | Coverage Δ | | |---|---|---| | [Linux](https://app.codecov.io/gh/domaindrivendev/Swashbuckle.AspNetCore/pull/3108/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Richard+Morris) | `90.50% <100.00%> (ø)` | | | [Windows](https://app.codecov.io/gh/domaindrivendev/Swashbuckle.AspNetCore/pull/3108/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Richard+Morris) | `90.50% <100.00%> (ø)` | | | [macOS](https://app.codecov.io/gh/domaindrivendev/Swashbuckle.AspNetCore/pull/3108/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Richard+Morris) | `90.50% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Richard+Morris#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.