Closed scanepa closed 6 years ago
In the CloudFormation and Terraform sections, it's mentioned: https://github.com/Dome9/onboarding-scripts/tree/master/AWS/cloudformation
Would you like to see it at the AWS/ level or is there more clarification needed in the specific sections as well?
Thanks, Alex
Alex, you're right, the readme in CF folder is clear, but if a user goes directly in the https://github.com/Dome9/onboarding-scripts/tree/master/AWS/cft_with_d9_api_automation and just grab the content of the https://github.com/Dome9/onboarding-scripts/tree/master/AWS/cloudformation directory and copy it into a S3 bucket without taking care of your README.md she/he can end up thinking she/he on-boarded her/his cloud but this not true.
So moving into the upper folder should be good.
My 2cents. Stefano
Ah - for the API automation script, it actually generates a new external ID and applies it.
allchar = string.ascii_letters + string.digits extid = "".join(choice(allchar) for x in range(randint(12, 18)))
So in that case they should be good to go. I'll add in some more clarification though.
You still need ID and KEY for API.
I read your code and I'm doing something similar using sceptre and cloudformation.
On 6 April 2018 at 01:52, Alex Corstorphine notifications@github.com wrote:
Ah - for the API automation script, it actually generates a new external ID and applies it.
allchar = string.ascii_letters + string.digits extid = "".join(choice(allchar) for x in range(randint(12, 18)))
So in that case they should be good to go. I'll add in some more clarification though.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Dome9/onboarding-scripts/issues/1#issuecomment-379118378, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB-8xYRfKU-aEVpK24-cuWIJGGzKKpzks5tlrxhgaJpZM4TG-mU .
It's in the readme:
Should I be adding in more info here or exiting the script if they don't exist?
Exiting the script should be a good solution.
All the best Stefano
On 16 April 2018 at 15:59, Alex Corstorphine notifications@github.com wrote:
It's in the readme:
- Ensure that both your Dome9 API keys and AWS API keys exist in this file as well.
Should I be adding in more info here or exiting the script if they don't exist?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Dome9/onboarding-scripts/issues/1#issuecomment-381629560, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB-89yFm2r8eJKeszj_VNa-Qquflbypks5tpLG4gaJpZM4TG-mU .
Please see the latest commit - it has been added.
Thanks! -Alex
if d9id or d9secret or d9mode or awskey or awssecret == "":
print ('Please ensure that all config settings in d9_aws_acct_add.conf are set.')
sys.exit()
I think that there is a missing part about how to use external ID and account arn in the Dome9 web interface.
thanks for you great work