search

domeide / sublime-docker

A Sublime Text plugin to use Docker Language Stacks as build systems
127 stars 12 forks source link

Is it necessary for C++ building container to run the executable file after compiling? #22

Closed k1xme closed 9 years ago

k1xme commented 9 years ago

I was gonna use this plugin to compile and run my single c++ file program, but turned out it only compile the program. So I added an attribute in the DockerBuildCommand class as follow: self.exec_cmd = " && ./a.out" if docker_image == "gcc" else "" # Run the executable file of cpp.

And appended it to build_cmd.

I don't know whether this little modification is needed by you guys.

If so, I will post a PR.

mjbright commented 9 years ago

Hi k1xme,

You're right that this is more consistent with the other build/run scenarii, so you could add this as a PR.

Regards, Mike.

On 31 July 2015 at 23:45, k1xme notifications@github.com wrote:

I was gonna use this plugin to compile and run my single c++ file program, but turned out it only compile the program. So I added an attribute in the DockerBuildCommand class as follow: self.exec_cmd = " && ./a.out" if docker_image == "gcc" else "" # Run the executable file of cpp.

And appended it to build_cmd.

I don't know whether this little modification is needed by you guys.

If so, I will post a PR.

— Reply to this email directly or view it on GitHub https://github.com/domeide/sublime-docker/issues/22.

k1xme commented 9 years ago

Hi Mike!

I've created a PR for this modification and a little bug in dockerutils.py. Please merge my PR.

Thanks!

k1xme commented 9 years ago

No body follows up with this?

mjbright commented 9 years ago

Hi,

Thanks for the reminder ... I'm afraid I'm just leaving on a trip ... I'll have a look on my return (setting a reminder for that) - sorry for the delay and thanks for your contribution.

Mike

On 2 November 2015 at 02:17, k1xme notifications@github.com wrote:

No body follows up with this?

— Reply to this email directly or view it on GitHub https://github.com/domeide/sublime-docker/issues/22#issuecomment-152885677 .

l0rd commented 9 years ago

I'v merged your PR. Thanks @k1xme for your help!