search

domenic / count-to-6

An intro to some ES6 features via a set of self-guided workshops.
Other
326 stars 76 forks source link

L10n fr #28

Closed tdd closed 9 years ago

tdd commented 9 years ago

Hey again Domenic,

As mentioned in #27, this is the second step of our recent work on globalizing and localizing count-to-6. This includes the commits referenced in #27, which will "disappear" when/if you merge that one first, to leave only FR-related commits for actual localization.

I remain, naturally, available for any discussion on this.

Looking forward to our getting that in,

Best,

tdd commented 9 years ago

Hey @domenic,

So, due to your feedback including lots of tweaks on commit messages, I had to rebase and force-push the entire branch, which means a number of your comments were lost in this PR (many are still visible in #27, based on the former early commits, though).

About wrapping: please consider my notes in the new, long-form commit message of c064433. If you're still adamant on no-wrapping, I'll rebase again and dewrap it, but I do feel it'd end up less usable for readers. Still, your house, your rules :wink:

Cheers,

tdd commented 9 years ago

Hey @domenic all done! I hope this meets your approval.

tdd commented 9 years ago

Hey @domenic, I believe these two latest commits now address all your remaining concerns.

Best,

domenic commented 9 years ago

Thanks! Merged as 33da9f4b4a57ed5032f8f1dc38f778307f1a8d64 and released as 0.7.0.

tdd commented 9 years ago

Awesome :tada:

Christophe Porteneuve tdd@tddsworld.com