FIX: Folder starting with the same "prefix" should not be a potential pa...

domenic / path-is-inside

Tests whether one path is inside another path

Other

41 stars 4 forks source link

FIX: Folder starting with the same "prefix" should not be a potential pa... #1

Closed pmarques closed 10 years ago

pmarques commented 10 years ago

Folder starting with the same "prefix" should not be a potential parent

domenic commented 10 years ago

Nice catch! Will merge and publish 1.0.1 as soon as I get some free time.

pmarques commented 10 years ago

Nice, and then I appreciate the include of that in npm, it will prevent an annoying "Adding a cache directory to the cache will make the world implode." when you set the npm cache in tmp folder (also used by npm), maybe should not be good idea but I found this issue because of that.

Should I open an issue on npm project to include this fix?

domenic commented 10 years ago

Nah, once I publish a new version we'll update the one in npm.

domenic commented 10 years ago

Merged as 15f3dda3cd42472e8fc79760fee5a603f2c1c0a5 with @kriskowal's optimization as 9277983c7f50b61667bc5ae005593df6ca988cdc; released as 1.0.1, and will put it into npm shortly.