search

domenic / path-is-inside

Tests whether one path is inside another path
Other
41 stars 4 forks source link

Handle relative paths #9

Open erik-krogh opened 4 years ago

erik-krogh commented 4 years ago

Uses path.resolve to handle relative paths.
path.resolve returns an absolute path without ../, so relative paths will work.

Fixes #6.

erik-krogh commented 4 years ago

Travis CI failed for some weird reason.
The console output is null, so it's definitely something on their end.

I have tested it locally, and all the existing test cases pass.

erik-krogh commented 4 years ago

@domenic can you look at this?

erik-krogh commented 4 years ago

Trying to close and re-open to force another CI run.

erik-krogh commented 4 years ago

mocha depends on any version of debug. And newer versions of debug use features that doesn't work in older versions of node. This broke the bulld (and would break any other build, the current master will not survive a rebuild).

I tried to fix the version of debug to some older version, but the version of node was from back in the days of nested node_modules folders, so that didn't help.

So I ended up bumping the node version in .travis.yml.