search

domenic / promises-unwrapping

The ES6 promises spec, as per September 2013 TC39 meeting
1.23k stars 94 forks source link

Drop dot notation for internal data properties #49

Closed Nathan-Wall closed 10 years ago

Nathan-Wall commented 10 years ago

See https://mail.mozilla.org/pipermail/es-discuss/2013-October/033962.html . Specifically Allen's statement "The dot notation is never used in the spec to refer to internal data properties."

Example from current draft (taken from IsPromise):

Return true if IsObject(x) and x.[[IsPromise]] is true.

I don't know what the correct notation would be, but [[IsPromise]] is an internal data property, so should probably not be accessed with dot notation.

This may have just been a notational convenience and something you intended to change later, but I didn't see a ticket for it so thought I would file one to help catch it early rather than later.

Great job so far, by the way!

domenic commented 10 years ago

Yeah, related to #34, but giving it its own issue makes sense.

domenic commented 10 years ago

Fixed by tonight/this morning's commits.