search

domenic / promises-unwrapping

The ES6 promises spec, as per September 2013 TC39 meeting
1.24k stars 95 forks source link

Implement January consensus: simplify resolution #99

Closed domenic closed 10 years ago

domenic commented 10 years ago

Due to the January consensus of removing flatMap from the future roadmap, we can drastically simplify the internals of the specification. I am excited.

juandopazo commented 10 years ago

Sadly, there was consensus in the meeting, but there were members not present who still disagree.

allenwb commented 10 years ago

is there an ETA for this update. I want the pending ES draft to reflect the January concensus

domenic commented 10 years ago

Unfortunately I cannot work on this until after Monday. Realistically that would mean the 31st at the latest, or possibly in the 25th--26th range if I can buckle down and find some time during the week.

domenic commented 10 years ago

@allenwb FYI I have made significant progress on this work over the weekend and hope to finish the rest on my plane ride tonight.

domenic commented 10 years ago

I think this is done. All tests pass etc.

I haven't squashed and merged into master yet because I want to review it with fresh eyes tomorrow and see if there are any tweaks that could be made to simplify or improve clarity. Also I could probably complete #78 by killing Identity and Thrower functions without much more effort.

But yeah, there you go. A big improvement IMO. The underlying concepts shine through much more clearly.

juandopazo commented 10 years ago

Is it not unwrapping on then anymore?

cscott commented 10 years ago

@juandopazo I see unwrapping at https://github.com/domenic/promises-unwrapping/compare/january-simplification?name=january-simplification#diff-04c6e90faac2675aa89e2176d2eec7d8R149

@domenic I'll try to update the es6-shim implementation this weekend (maybe after you finish #78?) to double-check your work.