search

domenic / restify-oauth2

A simple OAuth 2 endpoint for Restify
Other
294 stars 82 forks source link

Restify 4.x support #38

Closed NormandoHall closed 8 years ago

NormandoHall commented 9 years ago

Please, can you made restify 4.x support?

Regards

ckcfcc commented 9 years ago

yes. plz support restify 4

gmaniac commented 9 years ago

Sorry for the delay on this been really busy. I am working on this in the next couple of days.

I have added it I am working on getting tests to pass then I will update the package.

nmathon commented 9 years ago

:+1: Can you push a dev branch so we can test it with you / help you ?

gmaniac commented 9 years ago

Pushed, sorry I have not been able to work on this recently. All PRs welcome.

https://github.com/domenic/restify-oauth2/tree/develop

I removed all the things I have been testing, this is just the dependency updates.

jocull commented 8 years ago

You can setup npm to use the version with just the updated dependencies short-term:

"restify-oauth2": "git://github.com/domenic/restify-oauth2.git#cf5837d6b695c3d98264e53854b3b6d8f1fd4d2f",

Warning that I haven't tested it heavily yet, so make sure you abuse it first.

InsidiousForce commented 8 years ago

What's the status here? I see 4.0.3 of restify-oauth2 in npm, on github the latest release is 4.0.0 from april 2014 and the 4.0.3 in npm requires a peer of restify-3.x - is there a different fork that is working with restify 4.x or is this still the defacto? Best to use the commit above pointing to a fictional 4.0.4 for now? Thank you

jocull commented 8 years ago

I've been using the commit above until it's sorted. I haven't had any issues with it, but we're not in production yet either.

On Wednesday, December 30, 2015, Kurt Koller notifications@github.com wrote:

What's the status here? I see 4.0.3 of restify-oauth2 in npm, on github the latest release is 4.0.0 from april 2014 and the 4.0.3 in npm requires a peer of restify-3.x - is there a different fork that is working with restify 4.x or is this still the defacto? Best to use the commit above pointing to a fictional 4.0.4 for now? Thank you

— Reply to this email directly or view it on GitHub https://github.com/domenic/restify-oauth2/issues/38#issuecomment-168102445 .

InsidiousForce commented 8 years ago

Thanks for the info, it's working fine for me as well, also not in production.

AlexDobeck commented 8 years ago

Submitted a pull request to resolve tests. Hoping that is enough to get this deployed to npm #40.

Z-starts commented 8 years ago

+1 plz support

gmaniac commented 8 years ago

40 Merged and published