search

domenic / svg2png

Converts SVGs to PNGs, using PhantomJS
Other
586 stars 134 forks source link

headless chrome #93

Open pkra opened 7 years ago

pkra commented 7 years ago

Is there interest in switching from phantomjs to headless Chrome?

domenic commented 7 years ago

I'm a bit torn about this. It'd almost certainly give better results. But, it requires Chrome being installed on your system, whereas the PhantomJS version is nice and self-contained.

Probably the way to go is to add an option to switch between them. I'd love to see a PR that does that.

jthegedus commented 7 years ago

Just linking this as a suggestion

https://github.com/graphcool/chromeless

neocotic commented 7 years ago

Please see PR #96. I've implemented a solution using puppeteer. I still have a something to fix with it and there are some caveats (i.e. no sync, only async), but I'd like early feedback while I work on the last fix.

seangenabe commented 6 years ago

I agree; puppeteer would certainly be a great replacement.