search

domenic / worm-scraper

Scrapes the web serial Worm and its sequel Ward into an eBook format
Other
206 stars 48 forks source link

26 new fixes for substitutions.json #24

Closed CrackedP0t closed 3 years ago

CrackedP0t commented 3 years ago

I just finished reading Worm for the first time, and I loved it! Thanks so much for making this scraper. While I was reading, I bookmarked all the typos I found, and added them to substitutions.json.

I tried to stick as closely as possible to Wildbow's original writing, and make the fixes as unobtrusive as possible, but I'm absolutely open to other opinions on the changes.

domenic commented 3 years ago

Hi, thanks so much; this is great!

I don't think we should change the comma style choice (Oxford vs. not), as IMO that's an authorial style choice and depends on the situation. But otherwise these are great!

I'll push a few fixups, including undoing the Oxford comma changes, and then do a merge and release.

domenic commented 3 years ago

Alright, I merged this all as https://github.com/domenic/worm-scraper/compare/v4.11.0...v4.12.0 and released v4.12.0! Thanks so much!