search

domenicostefani / cpp-timbreID

An audio feature extraction library for the JUCE framework. Porting of wbrent/timbreID (original Pure Data external) .
GNU General Public License v3.0
12 stars 1 forks source link

Thoughts on Onset Detection #3

Open mikelange49 opened 3 years ago

mikelange49 commented 3 years ago

Hi Domenico.

It's Mickael (we've met at ADC). I don't have your email address so I'm writing here. I've modified the Pedalevite's Onset Detection plugin. You can build it with VisualStudio : https://github.com/mikelange49/pedalevite/blob/master/build/win/pedalevite.sln (sorry I didn't manage to include the VST dll in the .gitignore file)

This plugin indeed detects onsets VERY QUICKLY, with sometimes some false positives after, depending on the instrument and on the parameters. I think it can be a very good basis if we want to implement Luca TURCHET's idea : to combine one time-based and one frequency-based algorithm (which in our case could be NINOS)

Please let me know if you have any issue building the VST. Ciao.

domenicostefani commented 3 years ago

Hi Mickael, I'm really sorry but somehow Github didn't send me a notification for this issue. In the future if you need anything feel free to send me an email at domenico.stefani[at]unitn.it (You should find this address in my github profile page now). I got to 93/94% accuracy and 7 to 10ms of average latency with Aubio (more info ) but I would really like to improve accuracy. I will check Pedalevite out! Thank you, have a nice day.

Domenico