Split out synchronization classes into separate headers

domfarolino / browser

Simple browser components

4 stars 1 forks source link

Split out synchronization classes into separate headers #12

Closed musgravejw closed 4 years ago

musgravejw commented 4 years ago

Closes #4.

domfarolino commented 4 years ago

Noticed some more spacing things. We should go with:

Single space after comment on the same line as code (for namespaces, and everything)
Newline after start of namespace
Newline before end of namespace
Two space indents everywhere (except for class access modifiers)

musgravejw commented 4 years ago

Noticed some more spacing things. We should go with:

Single space after comment on the same line as code (for namespaces, and everything)

Newline after start of namespace

Newline before end of namespace

Two space indents everywhere (except for class access modifiers)

Cool, I will have to find a way to ignore these linting errors in CPPLint.

domfarolino commented 4 years ago

It's possible the linter should not be used, since it clearly is linting things that are not explicitly mentioned in the Google Style Guide.

musgravejw commented 4 years ago

(╯°□°)╯︵ ┻━┻

Just kidding, doesn't matter to me.

musgravejw commented 4 years ago

Fixed, my bad. check.h didn't seem to be added.