search

domfarolino / browser

Simple browser components
4 stars 1 forks source link

Add macOS target to bazel build file #17

Open musgravejw opened 4 years ago

musgravejw commented 4 years ago

Addresses https://github.com/domfarolino/browser/issues/14

Kind of a proof of concept, might need to refine this PR before merging.

I had to unzip the App folder for some reason, not sure why.

bazel build content/myApp
cd ./bazel-bin/content
unzip myApp.zip
./myApp.app/Contents/MacOS/myApp
domfarolino commented 4 years ago

You’ve requested reviewed, but also mention this needs to be cleaned up a bit first. Would you like me to take a look, or is it best to hold off?

musgravejw commented 4 years ago

@domfarolino Maybe high level feedback would be helpful at this point, since there are probably a few small changes. If you're ok with the direction, then we can look in more detail.

cc: @pmusgrave

musgravejw commented 4 years ago

@domfarolino makes sense. I will try to get that working next.

I was trying to embed this objective c code inline, so that the event loop code in main could use it, but it looked like that compiler directive only worked with GCC, so when I got it working with Bazel, I had to split it out into an objective c file.

musgravejw commented 3 years ago

I was trying to embed this objective c code inline, so that the event loop code in main could use it, but it looked like that compiler directive only worked with GCC, so when I got it working with Bazel, I had to split it out into an objective c file.

@domfarolino Running into an issue where I can't access the compiled Thread objects in base from the Objective C file, and the compiler isn't able to handle it when I include the header directly. Trying to find a work around.