[BUG] Keybinding move left/right moves diagonally on even 2x2 tiling layout

[thyttan]

Describe the bug On an even 2x2 tiling layout using keybindings to move window horizontally moves them diagonally instead.

To Reproduce Steps to reproduce the behavior:

1. On an empty workspace select an even 2x2 tiling layout.
2. Launch a terminal window.
3. Use keybinding Move window to right tile (I use alt + super + L).
4. Window snaps to the top left. (Up for discussion if this is expected or unexpected behaviour)
5. Use keybinding Move window to right tile again.
6. Window snaps to top right.
7. Use keybinding Move window to the left tile.
8. Window snaps to bottom left. (Unexpected!)
9. Use keybinding Move window to right tile again.
10. Window snaps to top right. (Unexpected!)

The repro above is what I did in the screencast below.

Screencast --removed--

Information (please complete the following):

• Tiling Shell version: 14 (after you fix of #156)
• GNOME version: 46.6

Additional context

[domferr]

Hey thanks a million for reporting this! I'm still improving the algorithm behind all of this, so it's great to have your feedback. I made some changes, would you like to give it a try?

• GNOME 42, 43 and 44: GNOME.42-44.tilingshell@ferrarodomenico.com.zip
• GNOME 45, 46 and 47: tilingshell@ferrarodomenico.com.zip

[thyttan]

Yes - that did the trick! Thanks!

[domferr]

Great! :star:

[thyttan]

While we're at it - I'll open another issue for a similar, but less clear cut case which I feel is unexpected but maybe is expected.

[domferr]

Ok thank you! Can you also check whether the issue occurs in the version I shared you above?

[thyttan]

Yes it does :) But again - it's not as clear cut unexpected as this issue was.