search

domhofmann / PRTween

Lightweight tween library for iOS
BSD 2-Clause "Simplified" License
459 stars 63 forks source link

period.tweenedLerp never removed #16

Closed rbrisita closed 12 years ago

rbrisita commented 12 years ago

When a PRTweenOperation expires it removes period.tweenedValue but not period.tweenedLerp. This is found on line 650 of PRTween.m.

domhofmann commented 12 years ago

Good finds on all of these. How much (if any) of your changes in your branch would you like to merge back? Don't wanna duplicate work and some of the changes look pretty good.

rbrisita commented 12 years ago

Well, I have changed the organization quite a bit and changed the infrastructure a little bit too. Basically, merging would add more files and take out the KVO and delayed calls. If you are open to it you can use what I have done, but I understand that developers have different organization and programming preferences. I have also added Doxygen documentation too. Let me know how you would like to proceed.

domhofmann commented 12 years ago

Yeah, I see that now.

I think I'll probably end up borrowing some of the code you've written for your branch. I'd like to add you to the contributor list if that's okay with you. Recently have had a lot of time to return to this library and turn it into what it needs to be. I plan on spending a lot more on it.

rbrisita commented 12 years ago

Sure, that would be great! I look forward to your changes. As for my branch development, I am at a content point, aka it's useful to me enough in my project, so I'll probably won't be updating it anytime soon.

domhofmann commented 12 years ago

Cool, will incorporate. Closing this ticket because it was fixed in a commit last night.