search

domhofmann / PRTween

Lightweight tween library for iOS
BSD 2-Clause "Simplified" License
459 stars 63 forks source link

Add support for ARC #19

Closed iheart2code closed 12 years ago

iheart2code commented 12 years ago

First off -- great job building this one-line tweener for Obj-C. Coming from ActionScript, this makes things really easy for me.

I have been programming for iOS 5 and taking advantage of Automatic Reference Counting. I'd recommend maybe making available a branch or something that includes ARC support. If you'd be interested in my modified copy, I can send it.

domhofmann commented 12 years ago

This is a good idea. I've been using ARC myself and am getting tired of passing the flags to libs that I haven't yet ported. Can you share what you have?

iheart2code commented 12 years ago

I am more than willing to do that. However -- I'm not sure how. Am I able to push to the repo? Should I e-mail you my code?

jwilling commented 12 years ago

You're going to want to submit a pull request so @dominikhofmann can easily bring your changes into the main repo. See a quick guide here: http://help.github.com/send-pull-requests/

domhofmann commented 12 years ago

Fixed in master! Thanks.