Move to a maintained fork

[rivera-ernesto]

Created an organization and forked the project to https://github.com/PRTween/PRTween.

Added the main contributors as owners and will add more periodically so pull request should be merged pretty quickly now.

---

Original description:

This project has been abandoned and before it dies it would be good to either:

• Appoint repository collaborators to handle pull requests and issues (e.g. @gillesguillemin, @jasonmarziani, @jawngee, @tonymcbeth, @jowie, @Tylerc230, @damiannz, and/or @cmezak).
• Mark @domhofmann's project as abandoned and forward people to an active fork.

This has been done for many projects where the project creator is too busy to maintain the repository and works great.

[damian0815]

sorry, i'm not interested in taking this on.. hope you find someone though!

[johndpope]

Hi Rivera,

I second you on this. This kind of code rot is baked in by github for all projects - where the first point of call is to create a fork. Collaboration is best which would nip this problem in the bud.

I think I have a fix for try / catch exception that should be committed. Sighh..... I suppose all this project has to be thrown away to use swift some day now.

    // @HACK: Come up with a better pattern for removing observers.
    @try {
        if ([tweenOperation observationInfo]) {
            [tweenOperation removeObserver:[PRTween sharedInstance] forKeyPath:@"period.tweenedValue"];
        }
    }
    @catch (id exception)
    {
        NSLog(@"exception:%@", exception);
    }
    @try {
        if ([tweenOperation observationInfo]) {
            [tweenOperation removeObserver:[PRTween sharedInstance] forKeyPath:@"period.tweenedLerp"];
        }
    }
    @catch (id exception)
    {
        NSLog(@"exception:%@", exception);
    }

[Tylerc230]

I've never maintained a project before but I've used this lib for a few things and would like to see it progress. I'm out of the country until early jan but would be willing to become a collaborator at that point.

On Tuesday, October 21, 2014, John Pope notifications@github.com wrote:

Hi Rivera,

I second you on this. This kind of code rot is baked in by github for all projects - where the first point of call is to create a fork. Collaboration is best which would nip this problem in the bud.

I think I have a fix for try / catch exception that should be committed. Sighh..... I suppose all this project has to be thrown away to use swift some day now.

// @HACK: Come up with a better pattern for removing observers.
@try {
    if ([tweenOperation observationInfo]) {
        [tweenOperation removeObserver:[PRTween sharedInstance] forKeyPath:@"period.tweenedValue"];
    }
}
@catch (id exception)
{
    NSLog(@"exception:%@", exception);
}
@try {
    if ([tweenOperation observationInfo]) {
        [tweenOperation removeObserver:[PRTween sharedInstance] forKeyPath:@"period.tweenedLerp"];
    }
}
@catch (id exception)
{
    NSLog(@"exception:%@", exception);
}

— Reply to this email directly or view it on GitHub https://github.com/domhofmann/PRTween/issues/41#issuecomment-59884219.

[rivera-ernesto]

Created an organization and forked the project to https://github.com/PRTween/PRTween. Added people in this thread as owners including @domhofmann .

All pull request should be made there.

[Tylerc230]

Awesome thanks.

On Tuesday, October 21, 2014, Ernesto Rivera notifications@github.com wrote:

Created an organization and forked the project to https://github.com/PRTween/PRTween. Added people in this thread as owners including @domhofmann https://github.com/domhofmann .

All pull request should be made there.

— Reply to this email directly or view it on GitHub https://github.com/domhofmann/PRTween/issues/41#issuecomment-59889083.

[Tylerc230]

Did you have any thoughts on a road map for this project beyond integrating pull requests (new features, API changes etc)?

On Tuesday, October 21, 2014, Tyler Casselman tylerc230@gmail.com wrote:

Awesome thanks.

On Tuesday, October 21, 2014, Ernesto Rivera <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

Created an organization and forked the project to https://github.com/PRTween/PRTween. Added people in this thread as owners including @domhofmann https://github.com/domhofmann .

All pull request should be made there.

— Reply to this email directly or view it on GitHub https://github.com/domhofmann/PRTween/issues/41#issuecomment-59889083.

[rivera-ernesto]

Not really at the moment. I hope the community will decide where to go from here.

[domhofmann]

I'd modernize the API (use blocks instead of function pointers, remove @synthesize usage) and add the ability to render tweens to CAKeyframeAnimations.