Block reward ratio is Quai/Qi, should be Qi/Quai

[jshorish]

In the results DataFrame (e.g. df available in the controller notebooks), the column "Block Reward Ratio" contains the ratio of the proposed block rewards as Quai / Qi. But the main results and visualizations rely upon e.g. kQi / kQuai, etc., and so this ratio should be updated to be Qi / Quai, i.e. its inverse.

(This is likely an artifact of the earlier required switch from Qi to Quai for the controller update parameter.)

[SeanMcOwen]

@jshorish Would you be ok with me putting to a later issue/next block of work? A few things run off the ratio (and flip it with 1/X depending on which side is needed) and I would worry about introducing any bugs this late. If you feel strongly on it I can still do it, just want to be cautious.

It might have also come that way from the original documentation I was reading.

[jshorish]

@SeanMcOwen Completely up to you--I noted the issue when trying to plot the "Block Reward Ratio" directly from the DataFrame and finding results exactly opposite those expected :-). So we can address if they raise it, otherwise no problem to defer if it's entangled in other areas.

Just for completeness, which original documentation referred to the ratio as quai/qi? I'm thinking this was the original research arc before the Quai team requested that kQuai was the controller's update parameter, but if there was any other communication from them would be good to know--thx in advance!

[SeanMcOwen]

@jshorish I don't remember exactly, just meant that likely I took it from one of the original documents and things changed since then!