search

dominant-strategies / go-quai

Official Go Implementation of the Quai Network
GNU General Public License v3.0
2.36k stars 456 forks source link

[Testing] - Write unit tests for access methods for Raw DB (pt 2) #1826

Open mibuono opened 1 month ago

mibuono commented 1 month ago

This is related to #1804 with Game of pointer's comment

As a part of this, can you please check to see what accessors are not being used.

didaunesp commented 1 month ago

ETX methods

WriteEtxSetProto, ReadEtxSet, WriteEtxSet, ReadEtx, WriteEtx, DeleteETX aren't being used anywhere but

DeleteEtxSet is being used on slice cleanCacheAndDatabaseTillBlock and ReadEtxSetProto is being used on freezer

Should I keep this methods?