dominant-strategies / go-quai

Official Go Implementation of the Quai Network
GNU General Public License v3.0
2.36k stars 456 forks source link

ETXs might be reinjected into the pool during re-orgs #1926

Open jdowning100 opened 6 days ago

jdowning100 commented 6 days ago

https://github.com/dominant-strategies/go-quai/blob/main/core/tx_pool.go#L1667 https://github.com/dominant-strategies/go-quai/blob/main/core/tx_pool.go#L1749 The code seems to allow inbound ETXs that are in a block that has been removed from the canonical chain to be 're-injected' into the pool, which is very bad. We should also add a check in addTx that prevents an ETX from entering the pool. The types.Sender(tx) check would crash the node on an ETX.