search

dominant-strategies / go-quai

Official Go Implementation of the Quai Network
GNU General Public License v3.0
2.39k stars 466 forks source link

Locked Quai redemptions break EVM fallback & receive calls #2326

Open wizeguyy opened 3 weeks ago

wizeguyy commented 3 weeks ago

Originally reported by Halborn in HAL-15

gameofpointers commented 3 weeks ago

Idk if this is needed anymore

mibuono commented 2 weeks ago

If the coinbase address is a contract it wont get the reward.

If someone specifies the coinbase address as the reward address, the only way we can process it is if we supply the function signature in the data field of the ETX.

ETX data field - If they don't supply the data field, they won't get the money.

If the TO is the contract address, we can check the data to see where the LMTs should go. First byte of the data is the lock. Data field is the going to have a special, conditional parsing for coinbases. First byte will be the lock duration, then process the data field normally.

This should get rid of the issue to break EVM fallback, and enable the liquid mining token.

jdowning100 commented 1 week ago

https://github.com/jdowning100/go-quai/commit/0bfb57ef37b05f1adf9469f937327d479c1819fd

wizeguyy commented 1 week ago

^ that is Jonathan's proposed fix