dominant-strategies / quaipay

Other
7 stars 5 forks source link

fix: setup of pfp with blockie on context #242

Closed juanmanso closed 1 year ago

juanmanso commented 1 year ago

Description

While implementing blockie pfps, we decided to store that uri string in the context and use that everywhere.

However, we found that the string might be a little too long and thus resulting in an issue while generating the QR code to share it.

Since this is a partial fix (the actual and complete fix would be to share the whole set of addresses for a contact), we defaulted on the send flow to use the address blockie if pfp is a zone.

That last part will be followed up in upcoming PRs.

Related links

Proof

Before After
image