search

dominch / redmine_highlightjs

A redmine plugin to highlight code blocks much better than coderay!
Other
23 stars 10 forks source link

Code block disappeared in IE8 #9

Closed aliramw closed 9 years ago

aliramw commented 9 years ago

I know that IE8 is devil... But, all of our company's laptops use IE8 as the standard working browser.

Highlight.js does not support IE8, so I think maybe the plugin should add some compatible code not to use highlight.js in IE8.

styles in fixes.css made code blocks hidden in IE8...

Krakozaber commented 9 years ago

-> https://github.com/isagalaev/highlight.js

dominch commented 9 years ago

HighlightJS won't support IE8, they dropped that two years ago and don't plan to continue that. It is easy to turn off highlighting and show blocks, but it's harder to conditionally turn on CodeRay again. I'll take a look what can be done about it,

dominch commented 9 years ago

@marilawang Please check out version from dev branch it should turn off plugin for few old browsers

dominch commented 9 years ago

Change is released in 1.0.2, if You still have a problem - let me know in new issue.

aliramw commented 9 years ago

the disappearing problem fixed, but codeRay is not working in IE8.

dominch commented 9 years ago

@marilawang please recheck dev branch, it seems that 1.0.2 had small issue with CodeRay switch.