Fix app.use() for Koa 2.x

dominhhai / koa-log4js

log4js-node supports Koa-middleware

https://www.npmjs.com/package/koa-log4

MIT License

82 stars 16 forks source link

Fix app.use() for Koa 2.x #3

Closed alt-jero closed 8 years ago

alt-jero commented 8 years ago

Unwrapped return value of getKoaLogger (Returns generator function instead of co.wrap() result)
Removed function call from yield next() to become simply yield next
Replaced passed in ctx variable with "this" provided by Koa framework

Fixes issue #2 Tested in my Koa app locally, it works for the Koa Middleware Use Case. ^^

alt-jero commented 8 years ago

Removed the co-requirement, and tested again just to be sure I didn't miss anything.

dominhhai commented 8 years ago

Did you test with Koa v2? I do NOT use generator for Koa v2. Currently, using co as a wrapper, but I will change to async/await as soon as Node released with Chrome v5.55

alt-jero commented 8 years ago

Oh my, That was a mishap... I did indeed test with Koa v1 instead of Koa v2, and essentially backported your v2.x branch to v1.... I'm glad you caught that. I was assuming I had Koa v2 installed because I just did

yarn add koa

and expected that I got the latest version! Will have to check on this.. it explains a lot! Sorry, and thanks! You can ignore the pull request and the issue I raised and closed!

dominhhai commented 8 years ago

👍