search

dominhhai / koa-log4js

log4js-node supports Koa-middleware
https://www.npmjs.com/package/koa-log4
MIT License
82 stars 16 forks source link

Re: Versions #4

Closed alt-jero closed 8 years ago

alt-jero commented 8 years ago

Sorry to bother you again, but I have a suggestion which may solve the version issue: If the 2.x branch is for Koa 2.x, would it make sense to add "koa": "^2.0.0" to the package.json dependencies? (And maybe even to the 1.x branch as "koa": "^1.0.0" for consistency?

dominhhai commented 8 years ago

v1: https://github.com/dominhhai/koa-log4js/blob/master/package.json#L3 v2: https://github.com/dominhhai/koa-log4js/blob/v2.x/package.json#L3

alt-jero commented 8 years ago

I mean:

"devDependencies": {
    "standard": "^6.0.8",
    "koa": "1.x.x"  //<<< Like that because if you then install it with koa 2.x it should complain, yes?
  }
dominhhai commented 8 years ago

Read it, please.