dominic-ks / bdvs-password-reset

WordPress - Allow users to reset their password using a random code via the REST API
GNU General Public License v3.0
9 stars 3 forks source link

Translation of the plugin #20

Open Ebeldev opened 1 year ago

Ebeldev commented 1 year ago

Hi,

We are using this great plugin on one of our site.

  1. Unfortunatly, I see that a lot of the strings are "ready" for translation, as you are using "__('string to translate', 'translation-slug')" , but there is no .pot file and missing a language folder.

  2. Could it be possible to have the text that goes in the email translatable ? The text is hard coded in this function bdpwr_send_password_reset_code_email.

We need to translate the plugin in different.

So far, we only change the text for the 'bdpwr_code_email_subject' and 'bdpwr_code_email_text' filters.

Would it be possible to have this ?

dominic-ks commented 1 year ago

Hello @Ebeldev, thanks for the message and for using the plugin!

Yes the plugin is translation ready but I haven't translated it, and I personally don't intend to, largely because I don't speak any other languages to a high enough standard to be confident in them.

There are two ways to translate a plugin, one is via the ,pot files and the other is directly on wp.org, you can see here people have contributed Spanish and Swedish, I would welcome it if you'd like to contribute another language via either method.

Good point regarding the email content and subject, though, yes I could add translation capability for those.