search

dominic-p / videojs-resolution-selector

Adds a resolution selector button to Video.js to allow users to manually adjust the video quality.
MIT License
88 stars 31 forks source link

preload="none" #1

Closed doconix closed 11 years ago

doconix commented 11 years ago

When preload="none" on the videojs tag, the loadedmetadata event never fires (line 111).

For example, I'm playing a video, switch resolutions, and it goes blank. It doesn't continue playing. It requires a new click to play again.

The reason is that loadedmetadata doesn't trigger until the metadata is loaded. And since I have preload="none", it doesn't load it until the user clicks again. Since the user already clicked once, I think we can assume he/she wants to continue playing.

I'm not really sure how to solve this one correctly. A quick solution is to switch to preload="metadata". That is a short term solution for me, but I'd really like to get away from it because I have lots of videos on one page.

Fantastic plugin, btw.

dominic-p commented 11 years ago

Hopefully this works for you. My thinking is that if a user is watching a video already and they click to change the resolution, it can't hurt to change the preload attribute at that point. I'm glad you like the plugin. Thanks.