search

dominic-p / videojs-resolution-selector

Adds a resolution selector button to Video.js to allow users to manually adjust the video quality.
MIT License
88 stars 31 forks source link

The menu which contain quality was disappear when mouse move. #16

Closed hxdev closed 9 years ago

hxdev commented 9 years ago

With VideoJS version 4.9 this plugin not work because the menu which contain qualities will disappear when mouse move to it.

Robinfr commented 9 years ago

Confirmed!

dominic-p commented 9 years ago

I haven't had a chance to test with VideoJS 4.9 yet. When I get some time, I'll take a look. In the mean time, pull requests and test cases (jsfiddle) are welcome. :)

Robinfr commented 9 years ago

Made jsfiddle for you http://jsfiddle.net/pzfuezhv/

dominic-p commented 9 years ago

Thanks for putting the fiddle together. That helps. I looked at this for a while today. No fix yet, but the problem seems to be that the .vjs-menu element gets added to the wrong part of the DOM (as a sibling instead of a child of .vjs-control-content).

I looked through some other plugins and most seem to be creating their buttons the same way I do, so I'm not sure what the correct way to add a button is in 4.9.

Robinfr commented 9 years ago

Did you notice the same bug in the other plugins?

dominic-p commented 9 years ago

Problem solved in latest release. See http://jsfiddle.net/ufyzwt5h/

hxdev commented 9 years ago

Work great after fixed :) Sorry because cannot contribute anything, I'm new to videojs plugin, I've try to read the way how to add button and menu of others plugin but still don't understand how to add simple button and menu to videojs control bar. :(